more work on the map trait and TreeMap/LinearMap #4594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the module much more discoverable, and is in line with the 'treemap' naming.
This legacy trait needs to be dropped in order to migrate to core::container::Map, which doesn't require @ and Copy, and will make proper use of borrowed pointers.
This isn't simpler (or faster) than just doing the copy in the caller, and it doesn't work for types that can be cloned but not copied.
it's pretty solid, at least relative to most of the other modules
|
Thanks, I'm running tests and if they pass, I'll merge this. |
|
Awaiting a fix for |
|
Currently some code duplication in the fix/expansion of the benchmark between the LinearMap/TreeMap functions. Getting rid of the code duplication results in a very strange borrow checking error (diff: https://gist.github.com/4616504, error: https://gist.github.com/4616785) |
|
Great, thanks for the hard work! |
catamorphism
added a commit
that referenced
this pull request
Jan 24, 2013
more work on the map trait and TreeMap/LinearMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently breaks test/bench/core-map.rs, which will need to be rewritten