add StorageDead handling
#45936
Merged
add StorageDead handling
#45936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
arielb1
reviewed
Nov 12, 2017
| // here, in dataflow vector | ||
| zero_to_one(sets.gen_set.words_mut(), *move_index); | ||
| match stmt.kind { | ||
| // skip move out for StorageDead |
There was a problem hiding this comment.
could you comment here why we are skipping the move out for StorageDead?
// this analysis only tries to find moves explicitly
// written by the user, so we ignore the move-outs
// created by `StorageDead` and at the beginning
// of a function.Also, it might be a better idea to handle the move outs for both StorageDead and the implicit move-out at the beginning of a function. Your call.
arielb1
suggested changes
Nov 12, 2017
arielb1
reviewed
Nov 12, 2017
| @@ -231,8 +231,13 @@ pub(crate) fn drop_flag_effects_for_location<'a, 'gcx, 'tcx, F>( | |||
| } | |||
| } | |||
| } | |||
| mir::StatementKind::StorageDead(local) => { | |||
There was a problem hiding this comment.
I don't think this is needed - we already iterate over move-outs the statement before.
|
@bors r+ |
|
📌 Commit 5a501cc has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 5a501cc8802cb3119e9180b23ff019d13b5997b8 with merge b8123036d2957f059bac389ebbffac65eee0a936... |
|
💔 Test failed - status-travis |
|
rebaseing |
mikhail-m1
force-pushed
the
mir-borrowck-storage-dead
branch
from
5a501cc to
9e35fd2
Compare
|
@bors r+ |
|
📌 Commit 9e35fd2 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #45642
r? @arielb1