Add more elements in the sidebar #45766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
kennytm
reviewed
Nov 5, 2017
src/test/rustdoc/sidebar-items.rs
Outdated
| // @has - '//*[@class="sidebar-links"]/a' 'foo' | ||
| // @has - '//*[@class="sidebar-title"]/a' 'Associated Constants' | ||
| // @has - '//*[@class="sidebar-links"]/a' 'BAR' | ||
| // @has - '//*[@class="sidebar-title"]/a' 'Associated Types' |
There was a problem hiding this comment.
[00:59:22] 14: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-title"]/a' 'Required Methods'
[00:59:22] 16: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-title"]/a' 'Provided Methods'
[00:59:22] 18: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-title"]/a' 'Associated Constants'
[00:59:22] 20: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-title"]/a' 'Associated Types'
[00:59:22] 31: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-title"]/a' 'Fields'
[00:59:22] 41: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-title"]/a' 'Variants'
[00:59:22] 50: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-title"]/a' 'Fields'
[00:59:22] 52: @has check failed
[00:59:22] `XPATH PATTERN` did not match
[00:59:22] // @has - '//*[@class="sidebar-links"]/a' 'u'
GuillaumeGomez
force-pushed
the
trait-methods-list
branch
3 times, most recently
from
ef9b7ed to
18af3eb
Compare
|
Working! |
ollie27
suggested changes
Nov 6, 2017
src/librustdoc/html/render.rs
Outdated
| @@ -3547,6 +3547,10 @@ fn small_url_encode(s: &str) -> String { | |||
| .replace("]", "%5D") | |||
| } | |||
|
|
|||
| fn small_html_encode(s: &str) -> String { | |||
There was a problem hiding this comment.
Why aren't you using Escape? &s appear in type parameters for impls so need to be escaped which Escape will handle but this doens't.
There was a problem hiding this comment.
I didn't understand the second part of your comment (and to answer the first, I didn't know it existed, I'll update!).
There was a problem hiding this comment.
impl<'a> Add<&'a i32> for i32 is a valid thing to attempt to print, so the & in there should be escaped properly in the html.
|
r=me with @ollie27's comment (and with travis) |
kennytm
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
trait-methods-list
branch
from
18af3eb to
ac398a3
Compare
|
Updated, let's wait for travis now. |
|
Updated. |
|
@bors r=QuietMisdreavus Travis is green and the code is now using |
|
📌 Commit ac398a3 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 8, 2017
…r=QuietMisdreavus Add more elements in the sidebar Fixes rust-lang#45740. r? @rust-lang/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45740.
r? @rust-lang/docs