Skip to content

Add "Buidling on *nix" sub-header #45293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2017
Merged

Add "Buidling on *nix" sub-header #45293

merged 1 commit into from
Oct 16, 2017

Conversation

joeratt
Copy link
Contributor

@joeratt joeratt commented Oct 14, 2017

Since there is a "Build on Windows" section, a simple sub-header here would help Windows users to know they need to keep reading.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2017
@kennytm
Copy link
Member

kennytm commented Oct 15, 2017 •
edited
Loading

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 15, 2017

📌 Commit 6500b3d has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2017
@rust-lang rust-lang deleted a comment from bors Oct 15, 2017
@rust-lang rust-lang deleted a comment from bors Oct 15, 2017
@bors
Copy link
Collaborator

bors commented Oct 16, 2017

⌛ Testing commit 6500b3d with merge a96ff3b...

bors added a commit that referenced this pull request Oct 16, 2017
@bors
Auto merge of #45293 - joeratt:patch-1, r=kennytm
a96ff3b 
Add "Buidling on *nix" sub-header

Since there is a "Build on Windows" section, a simple sub-header here would help Windows users to know they need to keep reading.
@bors
Copy link
Collaborator

bors commented Oct 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing a96ff3b to master...

@bors bors merged commit 6500b3d into rust-lang:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joeratt @rust-highfive @kennytm @bors @aturon