rustbuild: Set ignore-git based on channel
#43873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit automatically sets `ignore-git` to `true` in configuration if the configured channel is set to "dev" and otherwise no value for `ignore-git` has been specified. This'll help rebuilds locally whenever a new commit is made by ensuring that git information never makes its way to compiler crates in the first place. Closes rust-lang#43771
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -54,7 +54,7 @@ pub struct Config { | |||
| pub extended: bool, | |||
| pub sanitizers: bool, | |||
| pub profiler: bool, | |||
| pub ignore_git: bool, | |||
| pub ignore_git: Option<bool>, | |||
There was a problem hiding this comment.
I don't think we should make this an optional -- I've been trying to make Config as much a "source of truth" as possible without needing interpretation outside this file. We can save rust.ignore_git to a variable when loading and process the logic here.
|
Closing due to #43771 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit automatically sets
ignore-gittotruein configuration if theconfigured channel is set to "dev" and otherwise no value for
ignore-githasbeen specified. This'll help rebuilds locally whenever a new commit is made by
ensuring that git information never makes its way to compiler crates in the
first place.
Closes #43771