Skip to content

Add a note to unused variables #43850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

GuillaumeGomez
Copy link
Member

Fixes #26720.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Aug 14, 2017

Not sure about automaticallly suggesting to use _ - that has drastically different effects with e.g. locks.

@carols10cents carols10cents added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 14, 2017
@GuillaumeGomez
Copy link
Member Author

That's why we propose both.

@arielb1
Copy link
Contributor

arielb1 commented Aug 16, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 16, 2017

📌 Commit 9b0607a has been approved by arielb1

@bors
Copy link
Collaborator

bors commented Aug 16, 2017

⌛ Testing commit 9b0607a with merge c886246...

bors added a commit that referenced this pull request Aug 16, 2017
@bors
Copy link
Collaborator

bors commented Aug 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing c886246 to master...

@bors bors merged commit 9b0607a into rust-lang:master Aug 16, 2017
@GuillaumeGomez GuillaumeGomez deleted the unused-variable-lint branch August 16, 2017 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants