-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make $crate
a keyword
#42902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make $crate
a keyword
#42902
Conversation
LGTM overall. I still don't really think of If we're making it a keyword though, could we put it next to its counterpart |
That's true, it just needs to "quack like a keyword" (path segment keyword, to be precise), i.e. answer "yes" to questions "is it reserved?" and "can it be used in a path segment?". So, making it a keyword is the simplest solution.
I suspect (I'll return to this PR in a few days.) |
Makes sense.
Agreed, I was just saying we should declare the reserved identifier placeholders next to each other, not interspersed with the traditional keywords (or we could also separate/refactor out "reserved identifier placeholders" further). |
Updated. |
Thanks! @bors r+ |
📌 Commit b33fd6d has been approved by |
Make `$crate` a keyword Fixes #42898 r? @jseyfried or @nrc
☀️ Test successful - status-appveyor, status-travis |
Fixes #42898
r? @jseyfried or @nrc