-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 5 pull requests #42573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #42573
Conversation
frewsxcv
commented
Jun 9, 2017
- Successful merges: Make rustdoc.js use license comments. #42307, Vec<T> is pronounced 'vec' #42385, Ignore variadic FFI test on AArch64 #42531, doc: a more complete explanation, and a better example #42551, Update TRPL link in README.md #42558
- Failed merges:
Make rustdoc.js use license comments. This will ensure that JS minifiers and the like will preserve the license statement even after minimisation.
Vec<T> is pronounced 'vec' I've never heard it pronounced "vector". Is this an outdated recommendation? (or have I been doing it wrong all this time) r? @steveklabnik
…=nagisa Ignore variadic FFI test on AArch64 I've cross compiled Rust to `aarch64-linux-gnu`, and tried to run the compile-fail tests, but `variadic-ffi.rs` fails with the following error: ``` The ABI `"stdcall"` is not supported for the current target [E0570] ``` The test seems to be ignored on (32-bit) ARM, so I turned it off for AArch64 too.
…r=steveklabnik doc: a more complete explanation, and a better example
Update TRPL link in README.md
Some changes occurred in HTML/CSS. |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ p=10 |
📌 Commit 3be7f8b has been approved by |
☀️ Test successful - status-appveyor, status-travis |