Skip to content

Fix off-by-one error in column number in explain_span. #42062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2017
Merged

Fix off-by-one error in column number in explain_span. #42062

merged 1 commit into from
May 21, 2017

Conversation

fhartwig
Copy link
Contributor

Fixes #41938

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

Ordinarily, I'd say let's add a test, but I'm not sure it's worth it in this particular case, since I think those error messages are fairly fragile and likely to be changed.

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 17, 2017

📌 Commit f24b168 has been approved by nikomatsakis

@fhartwig
Copy link
Contributor Author

Ok, turns out there were tests covering this. I'll push an update once I've fixed them all.

@fhartwig fhartwig force-pushed the fix-off-by-one-span branch from f24b168 to eb703f7 Compare May 17, 2017 22:22
@aidanhs aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 18, 2017
@fhartwig
Copy link
Contributor Author

fhartwig commented May 18, 2017 •
edited
Loading

Okay, I've fixed the tests and amended the commit.

@Mark-Simulacrum
Copy link
Member

@bors r= nikomatsakis

@bors
Copy link
Collaborator

bors commented May 20, 2017

📌 Commit eb703f7 has been approved by ``

@Mark-Simulacrum
Copy link
Member

err... no

@bors r-

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented May 20, 2017

📌 Commit eb703f7 has been approved by nikomatsakis

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 20, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42062 - fhartwig:fix-off-by-one-span, r=nik…
2945642 
…omatsakis

Fix off-by-one error in column number in `explain_span`.

Fixes rust-lang#41938
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 20, 2017
Merged
bors added a commit that referenced this pull request May 21, 2017
@bors
Auto merge of #42130 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
7ac844f 
Rollup of 6 pull requests

- Successful merges: #41892, #42062, #42091, #42093, #42098, #42127
- Failed merges:
@bors bors merged commit eb703f7 into rust-lang:master May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fhartwig @rust-highfive @nikomatsakis @bors @Mark-Simulacrum @aidanhs