Skip to content

travis: See if OSX generates crash dumps #40769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2017

Conversation

alexcrichton
Copy link
Member

I know for a fact we've had sccache segfault on various platforms and we've also
historically had a lot of problems with the linker on OSX. Let's just poke
around in the crash log directory to see if anything exists. If in the future we
see a build we think segfaulted and there's contents here then we can add some
bits that actually print out the logs.

I know for a fact we've had sccache segfault on various platforms and we've also
historically had a lot of problems with the linker on OSX. Let's just poke
around in the crash log directory to see if anything exists. If in the future we
see a build we think segfaulted *and* there's contents here then we can add some
bits that actually print out the logs.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

There's a suspicion that the OOM killer is killing sccache (maybe) so this adds
some logging to test out that assumption to see if anything dies and is logged
by `dmesg`
@alexcrichton
Copy link
Member Author

I threw on an extra commit to help debug situations where anything is killed by the OOM killer as that's also a suspicion for what's going on.

@nikomatsakis
Copy link
Contributor

Seems good.

@nikomatsakis
Copy link
Contributor

@bors r+ p=1

  • Giving high priority because getting infrastructure up and going is key.

@bors
Copy link
Collaborator

bors commented Mar 24, 2017

📌 Commit 37fd132 has been approved by nikomatsakis

@bors
Copy link
Collaborator

bors commented Mar 24, 2017

⌛ Testing commit 37fd132 with merge f2036c7...

bors added a commit that referenced this pull request Mar 24, 2017
travis: See if OSX generates crash dumps

I know for a fact we've had sccache segfault on various platforms and we've also
historically had a lot of problems with the linker on OSX. Let's just poke
around in the crash log directory to see if anything exists. If in the future we
see a build we think segfaulted *and* there's contents here then we can add some
bits that actually print out the logs.
@bors
Copy link
Collaborator

bors commented Mar 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing f2036c7 to master...

@bors bors merged commit 37fd132 into rust-lang:master Mar 24, 2017
@alexcrichton alexcrichton deleted the osx-crash-logs branch April 4, 2017 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants