Hide a few more standard library symbols #39252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
less-exports
branch
from
940f06a to
8abbe6d
Compare
Member
Author
Member
|
Looks good to me! |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 8abbe6d has been approved by |
Collaborator
|
⌛ Testing commit 8abbe6d with merge b19c8e1... |
Collaborator
|
💔 Test failed - status-appveyor |
alexcrichton
force-pushed
the
less-exports
branch
from
8abbe6d to
5934a13
Compare
Member
Author
|
@bors: r=nrc |
Collaborator
|
📌 Commit 5934a13 has been approved by |
Collaborator
|
⌛ Testing commit 5934a13 with merge 018087c... |
Collaborator
|
💔 Test failed - status-travis |
alexcrichton
force-pushed
the
less-exports
branch
from
5934a13 to
e80b7ba
Compare
Member
Author
|
@bors: r=nrc |
Collaborator
|
📌 Commit e80b7ba has been approved by |
Collaborator
|
⌛ Testing commit e80b7ba with merge 1057387... |
Collaborator
|
💔 Test failed - status-travis |
This hides symbols from various unstable and implementation-detail crates of the standard library. Although typically transitive exported `pub extern` functions are exported from cdylibs, these crates aren't necessary as they're all implementation details. Closes rust-lang#34493
We don't want these symbols exported from the standard library, this is just an internal implementation detail of the standard library currently. Closes rust-lang#34984
alexcrichton
force-pushed
the
less-exports
branch
from
e80b7ba to
3d6f263
Compare
Member
Author
|
@bors: r=nrc |
Collaborator
|
📌 Commit 3d6f263 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Jan 27, 2017
Hide a few more standard library symbols These commits touch up some of the symbol visibility rules for some crates related to the standard library, notably: * Symbols that are `pub extern` and `#[no_mangle]` which are internal-to-rust ABI things are no longer at the `C` export level, but the `Rust` export level. This includes allocators, panic runtimes, and compiler builtins. * The libbacktrace library is now compiled with `-fvisibility=hidden` to ensure that we don't export those symbols.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
brson
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits touch up some of the symbol visibility rules for some crates related to the standard library, notably:
pub externand#[no_mangle]which are internal-to-rust ABI things are no longer at theCexport level, but theRustexport level. This includes allocators, panic runtimes, and compiler builtins.-fvisibility=hiddento ensure that we don't export those symbols.