Skip to content

Remove old fixed-length vector syntax #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

bstrie
Copy link
Contributor

@bstrie bstrie commented Oct 12, 2012

Addresses #3664.

@catamorphism
Copy link
Contributor

One question: do we want to use the self.obsolete() machinery here instead of just making the old syntax erroneous? (See calls to self.obsolete() in syntax::parse::parser for examples...)

@brson
Copy link
Contributor

brson commented Oct 20, 2012

I would like to parse all obsolete syntax for 0.5 if we can (they should be minimal from here out). In this case it probably means taking those few bits of code removed from the parser and putting them into try_foo methods in obsolete.rs. This is probably a subject we should discuss as a group though.

@brson
Copy link
Contributor

brson commented Oct 20, 2012

obsolete syntax tests are all in compile-fail/obsolete-syntax.rs

@brson
Copy link
Contributor

brson commented Oct 21, 2012

I have a branch here that parses the old syntax still. Will merge shortly.

@brson
Copy link
Contributor

brson commented Oct 21, 2012

Hm, this also takes out the fixed length string syntax, str/N, that I didn't even know still existed. Do we have an alternative syntax for strings or are we simply planning to not have them? I think the later (&static/str seems fine for all practical string usage).

The affected test case is compile-fail/estr-subtyping.

@brson
Copy link
Contributor

brson commented Oct 21, 2012

OK. Pushed to incoming. Thanks!

@brson brson closed this Oct 21, 2012
bors pushed a commit to rust-lang-ci/rust that referenced this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants