-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Mention where std::vec
structs originate from.
#34818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! @bors: r+ rollup |
📌 Commit 528de81 has been approved by |
This patch causes a link check failure, see #34819. Excerpt from the log:
|
Fixed in the latest force push. diff --git a/src/libcollections/vec.rs b/src/libcollections/vec.rs
index f6861c0..b51b971 100644
--- a/src/libcollections/vec.rs
+++ b/src/libcollections/vec.rs
@@ -1604,8 +1604,8 @@ impl<'a, T> FromIterator<T> for Cow<'a, [T]> where T: Clone {
/// An iterator that moves out of a vector.
///
-/// This `struct` is created by the `into_iter` method on [`Vec`] (provided by
-/// the [`IntoIterator`] trait).
+/// This `struct` is created by the `into_iter` method on [`Vec`][`Vec`] (provided
+/// by the [`IntoIterator`] trait).
///
/// [`Vec`]: struct.Vec.html
/// [`IntoIterator`]: ../iter/trait.IntoIterator.html |
/// by the [`IntoIterator`] trait). | ||
/// | ||
/// [`Vec`]: struct.Vec.html | ||
/// [`IntoIterator`]: ../iter/trait.IntoIterator.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to change this to ../../std/iter/trait.IntoIterator.html
so the link works from the collections
docs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, didn't think about the collection docs getting generated. Will force push shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest force push includes this change.
@bors: r+ rollup |
📌 Commit cf21a7b has been approved by |
Mention where `std::vec` structs originate from. None
No description provided.