fail obligations that depend on erroring obligations #34605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
beta-nominated
| @@ -0,0 +1,11 @@ | |||
| fn main() { | |||
|
r=me with test fixed |
Fix a bug where an obligation that depend on an erroring obligation would be regarded as successful, leading to global cache pollution and random lossage. Fixes rust-lang#33723. Fixes rust-lang#34503.
arielb1
force-pushed
the
bug-in-the-jungle
branch
from
9aba9d4 to
201cdd3
Compare
|
@bors r=eddyb I would still like @nikomatsakis or @pnkfelix to look at this before beta-accepting. |
|
📌 Commit 201cdd3 has been approved by |
|
@bors p=1 |
bors
added a commit
that referenced
this pull request
Jul 2, 2016
fail obligations that depend on erroring obligations Fix a bug where an obligation that depend on an erroring obligation would be regarded as successful, leading to global cache pollution and random lossage. Fixes #33723. Fixes #34503. r? @eddyb since @nikomatsakis is on vacation beta-nominating because of the massive lossage potential (e.g. with `Copy` this could lead to random memory leaks), plus this is a regression.
|
Lgtm, let's put this into the beta branch |
|
Discussed with compiler team in email as well and sentiment was that this is small enough and important enough to backport, accepting for backport. |
alexcrichton
added
the
beta-accepted
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where an obligation that depend on an erroring obligation would
be regarded as successful, leading to global cache pollution and random
lossage.
Fixes #33723.
Fixes #34503.
r? @eddyb since @nikomatsakis is on vacation
beta-nominating because of the massive lossage potential (e.g. with
Copythis could lead to random memory leaks), plus this is a regression.