-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Don't translate vtable methods with Self: Sized bounds. #34419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
This looks good to me but I don't feel competent enough to r+ this on my own. |
cc @rust-lang/compiler |
This looks like it could just be |
@Aatch The effect is opposite: |
@eddyb oh right, I missed that. Seems fine then. |
@bors r+ |
📌 Commit 096ae80 has been approved by |
Don't translate vtable methods with Self: Sized bounds. Fixes #34416.
Discussed with compiler team in email and sentiment was that this is small enough and important enough to backport, accepting for backport. |
Fixes #34416.