Skip to content

Don't translate vtable methods with Self: Sized bounds. #34419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2016

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jun 23, 2016

Fixes #34416.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister
Copy link
Member

This looks good to me but I don't feel competent enough to r+ this on my own.

@michaelwoerister
Copy link
Member

cc @rust-lang/compiler

@Aatch
Copy link
Contributor

Aatch commented Jun 24, 2016

This looks like it could just be self.object_safety_violation_for_method(...).is_none(), since it's basically identical to the function above it.

@eddyb
Copy link
Member Author

eddyb commented Jun 24, 2016

@Aatch The effect is opposite: Self: Sized methods never have object-safety implications, so .is_none() would return true, but you want false because they're not in the vtable.

@Aatch
Copy link
Contributor

Aatch commented Jun 27, 2016

@eddyb oh right, I missed that. Seems fine then.

@Aatch
Copy link
Contributor

Aatch commented Jun 27, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 27, 2016

📌 Commit 096ae80 has been approved by Aatch

@bors
Copy link
Collaborator

bors commented Jun 27, 2016

⌛ Testing commit 096ae80 with merge b42884f...

bors added a commit that referenced this pull request Jun 27, 2016
Don't translate vtable methods with Self: Sized bounds.

Fixes #34416.
@bors bors merged commit 096ae80 into rust-lang:master Jun 27, 2016
@eddyb eddyb deleted the virtually-inexistent branch June 27, 2016 11:57
@pnkfelix pnkfelix added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2016
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 3, 2016
@alexcrichton
Copy link
Member

Discussed with compiler team in email and sentiment was that this is small enough and important enough to backport, accepting for backport.

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants