Skip to content

Fixed: conflicting spelling of "Jon Snow" #34134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hoodie
Copy link
Contributor

@hoodie hoodie commented Jun 7, 2016

I probably had not even noticed, if there hadn't been a different spelling in the error index.

Cheers
Winter is Coming!

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Oh damn it! Thanks so much for this fix!

Use the force Harry!

Gandalf

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 7, 2016

📌 Commit 4761de6 has been approved by GuillaumeGomez

@hoodie hoodie force-pushed the bug/john_and_jon branch from a110e7a to b602e06 Compare June 7, 2016 13:28
@hoodie hoodie force-pushed the bug/john_and_jon branch from b602e06 to af691a7 Compare June 7, 2016 13:30
@brson
Copy link
Contributor

brson commented Jun 7, 2016

Nice.

@hoodie
Copy link
Contributor Author

hoodie commented Jun 8, 2016

@GuillaumeGomez I had pushed another changed after 4761de6

@GuillaumeGomez
Copy link
Member

@hoodie: Arf. Please squash your commits and then I r+ again.

@bors: r-

@hoodie
Copy link
Contributor Author

hoodie commented Jun 8, 2016

There we go #34160 @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Why didn't you do it directly in here? :-/

Well, I close this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants