run rustfmt on libcollections module #33966
Conversation
|
r? @gankro (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @Manishearth cc to @nrc |
| @@ -986,7 +992,7 @@ impl<A> Extend<A> for LinkedList<A> { | |||
| } | |||
|
|
|||
| impl<I: IntoIterator> SpecExtend<I> for LinkedList<I::Item> { | |||
| default fn spec_extend(&mut self, iter: I) { | |||
| fn spec_extend(&mut self, iter: I) { | |||
There was a problem hiding this comment.
A default has been stripped here.
|
☔ The latest upstream changes (presumably #33947) made this pull request unmergeable. Please resolve the merge conflicts. |
| impl<T> ToOwned for T where T: Clone { | ||
| impl<T> ToOwned for T | ||
| where T: Clone | ||
| { |
There was a problem hiding this comment.
Why is the parenthesis going back to line? That's quite ugly. :-/
There was a problem hiding this comment.
(rustfmt bug again)
I think this is intentional though, since the where clause was indented
There was a problem hiding this comment.
It is intentional - we do this by hand with where clauses too
|
As much as I like rustfmt, some changes are very ugly. :-/ |
|
The |
|
Needs a rebase and some fixes. Closing for now, feel free to reopen if you finish these. Thanks! |
|
Closing due to inactivity, but feel free to resubmit with a rebase! |
No description provided.