Skip to content

Resolved rustdoc crash (#33678) by aborting instead of unwrapping. #33702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2016
Merged

Resolved rustdoc crash (#33678) by aborting instead of unwrapping. #33702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/librustdoc/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,8 @@ pub fn run_core(search_paths: SearchPaths,
&arenas,
&name,
|tcx, _, analysis, result| {
// Return if the driver hit an err (in `result`)
if let Err(_) = result {
return None
sess.fatal("Compilation failed, aborting rustdoc");
}

let _ignore = tcx.dep_graph.in_ignore();
Expand Down Expand Up @@ -206,6 +205,6 @@ pub fn run_core(search_paths: SearchPaths,
v.clean(&ctxt)
};

Some((krate, ctxt.renderinfo.into_inner()))
}), &sess).unwrap()
(krate, ctxt.renderinfo.into_inner())
}), &sess)
}