Rollup of 9 pull requests #32882
Merged
Rollup of 9 pull requests #32882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Apr 11, 2016
steveklabnik
commented
- Successful merges: Add doc examples for Iter and IterMut #32768, add regression test for #32505 #32802, Adds data race in docs #32815, Read "is-like-msvc" target option from JSON #32823, resolve: import resolution diagnostics #32849, Add some missing commas and missing titles/formatting #32854, Bit-magic for faster is_char_boundary #32862, Fix Windows UNC paths in std::path docs #32870, Match signed/unsigned integer type docs #32873
- Failed merges:
The asm generated for b < 128 || b >= 192 is not ideal, as it computes both sub-inequalities. This patch replaces it with bit magic. Fixes rust-lang#32471
* Copy documentation from signed implementation to unsigned implementation, where necessary. * Use signed integers in signed documentation, where possible.
…abnik Add doc examples for Iter and IterMut Fixes rust-lang#29374. r? @steveklabnik
add regression test for rust-lang#32505 Fixes rust-lang#32505 r? @eddyb
Adds data race in docs Thanks for all your hard work! This is in reference to rust-lang#32733 I know there has been a discussion about this on PR rust-lang#32538 so you are welcome to keep the code as is or merge my documentation in. Let me know what you think and/or if you want me to modify anything!
Read "is-like-msvc" target option from JSON This is in reference to rust-lang#32818.
…tics, r=eddyb resolve: import resolution diagnostics This improves the diagnostics for failing import resolutions (fixes rust-lang#32833). r? @eddyb
…labnik Add some missing commas and missing titles/formatting Fixes rust-lang#29373. r? @steveklabnik
Bit-magic for faster is_char_boundary The asm generated for b < 128 || b >= 192 is not ideal, as it computes both sub-inequalities. This patch replaces it with bit magic. Fixes rust-lang#32471
Fix Windows UNC paths in std::path docs
Match signed/unsigned integer type docs * Copy documentation from signed implementation to unsigned implementation, where necessary. A few functions had elaborate docs in the signed version but not in the unsigned version. This probably happenned because the signed version is at the top and the author didn't realize they had to update the documentation in both locations. * Use signed integers in signed documentation, where possible. r? @steveklabnik
|
@bors: r+ p=1 |
|
📌 Commit 55e90bb has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 55e90bb with merge a68a291... |
|
@bors: retry force clean |
|
⌛ Testing commit 55e90bb with merge 081fdc1... |
|
@bors: retry force clean |
bors
added a commit
that referenced
this pull request
Apr 11, 2016
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors: retry On Mon, Apr 11, 2016 at 3:17 PM, bors [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.