Skip to content

Warn for type parameter defaults on impl blocks #32817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2016
Merged

Warn for type parameter defaults on impl blocks #32817

merged 1 commit into from
Apr 13, 2016
+27 −14

Conversation

jseyfried
Copy link
Contributor

Warn for type parameter defaults on impl blocks (fixes #31543).
r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 11, 2016

📌 Commit 7c73b9e has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

thanks :)

@bors
Copy link
Collaborator

bors commented Apr 13, 2016

⌛ Testing commit 7c73b9e with merge 6136a86...

bors added a commit that referenced this pull request Apr 13, 2016
@bors
Auto merge of #32817 - jseyfried:warn_impl_param_defaults, r=nikomats…
6136a86 
…akis

Warn for type parameter defaults on impl blocks

Warn for type parameter defaults on impl blocks (fixes #31543).
r? @nikomatsakis
@bors
Copy link
Collaborator

bors commented Apr 13, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 7c73b9e into rust-lang:master Apr 13, 2016
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 13, 2016
@bluss
Copy link
Member

bluss commented Apr 13, 2016

Thank you!

@jseyfried jseyfried deleted the warn_impl_param_defaults branch February 12, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn for type parameter defaults on impl blocks
4 participants
@jseyfried @nikomatsakis @bors @bluss