process cycles as soon as they are detected #32582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ~~~ (*) see above | ||
| debug!("process_child_obligations: cycle index = {}", index); | ||
|
|
||
| if coinductive_match(selcx, &obligation, &backtrace) { |
There was a problem hiding this comment.
just realized that this is a bug -- we are overlooking the pending_obligation, which is at the logical "top" of the backtrace here
|
☔ The latest upstream changes (presumably #32439) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@nikomatsakis OK, I've reviewed this and it's a clear improvement. r=me after a rebase. |
We used to wait for the recursion limit, but that might well be too long!
When deciding on a coinductive match, we were examining the new obligation and the backtrace, but not the *current* obligation that goes in between the two. Refactoring the code to just have the cycle given as input also made things a lot simpler.
nikomatsakis
force-pushed
the
issue-32326
branch
from
4f798f8 to
6a749c7
Compare
|
@bors r=aturon |
|
📌 Commit 6a749c7 has been approved by |
|
@bors r=aturon |
|
📌 Commit e733b86 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to wait for the recursion limit, but that might well be too
long!
Fixes #32326
r? @aturon