-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make warnings of renamed and removed lints themselves lints #32219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nominating for beta because this fixes the unsightly |
r=me, but the travis failure looks legit:
|
Discussed in @rust-lang/compiler meeting. We are not sure if this is a good candidate for beta uplift or not. It's not fixing a regression per se -- but I guess it will depend on how many such warnings show up. Also, the code is mildly non-trivial (as evidenced by travis failures). |
FWIW I still see this warning a few times per day due to crates bringing in older versions of winapi or older versions of libc |
Looking into the failure. |
@bors r=alexcrichton |
📌 Commit bcc291f has been approved by |
☔ The latest upstream changes (presumably #32309) made this pull request unmergeable. Please resolve the merge conflicts. |
🔒 Merge conflict |
This adds the `renamed_and_removed_lints` warning, defaulting to the warning level. Fixes rust-lang#31141
@bors r=alexcrichton |
📌 Commit addde1f has been approved by |
Make warnings of renamed and removed lints themselves lints This adds the `renamed_and_removed_lints` warning, defaulting to the warning level. Fixes #31141
This passed on all but android but apparently that bot disappeared so merging manually. |
compiler team discussion concludes that since actively developed (and warning-free) crates should not themselves cause problems downstream, and thus the only problem here is with older version or abandoned crates, combined with fact that such crates will eventually be painless to pull in (once this PR hits stable in <=12 weeks), means that its not crucial to backport this to beta. |
This adds the
renamed_and_removed_lints
warning, defaultingto the warning level.
Fixes #31141