Skip to content

Make warnings of renamed and removed lints themselves lints #32219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2016

Conversation

brson
Copy link
Contributor

@brson brson commented Mar 12, 2016

This adds the renamed_and_removed_lints warning, defaulting
to the warning level.

Fixes #31141

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2016
@brson
Copy link
Contributor Author

brson commented Mar 12, 2016

Nominating for beta because this fixes the unsightly raw_pointer_derive warnings that show up in a lot of cargo build output.

@alexcrichton
Copy link
Member

r=me, but the travis failure looks legit:

---- [run-pass] run-pass/ifmt.rs stdout ----

error: compilation failed!
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs -L x86_64-unknown-linux-gnu/test/run-pass/ --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/run-pass/ifmt.stage2-x86_64-unknown-linux-gnu.run-pass.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/run-pass/ifmt.stage2-x86_64-unknown-linux-gnu --cfg rtopt -C rpath -O -L x86_64-unknown-linux-gnu/rt
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:15:10: 15:26 error: lint unknown_features has been renamed to unused_features
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:15 #![allow(unknown_features)]
                                                                        ^~~~~~~~~~~~~~~~
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:13:9: 13:17 note: lint level defined here
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:13 #![deny(warnings)]
                                                                       ^~~~~~~~
error: aborting due to previous error

------------------------------------------

thread '[run-pass] run-pass/ifmt.rs' panicked at 'explicit panic', /home/travis/build/rust-lang/rust/src/compiletest/runtest.rs:1651
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    [run-pass] run-pass/ifmt.rs

@alexcrichton alexcrichton self-assigned this Mar 14, 2016
@nikomatsakis
Copy link
Contributor

Discussed in @rust-lang/compiler meeting. We are not sure if this is a good candidate for beta uplift or not. It's not fixing a regression per se -- but I guess it will depend on how many such warnings show up. Also, the code is mildly non-trivial (as evidenced by travis failures).

@alexcrichton
Copy link
Member

FWIW I still see this warning a few times per day due to crates bringing in older versions of winapi or older versions of libc

@brson
Copy link
Contributor Author

brson commented Mar 18, 2016

Looking into the failure.

@brson
Copy link
Contributor Author

brson commented Mar 18, 2016

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 18, 2016

📌 Commit bcc291f has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 18, 2016

☔ The latest upstream changes (presumably #32309) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Mar 20, 2016

🔒 Merge conflict

This adds the `renamed_and_removed_lints` warning, defaulting
to the warning level.

Fixes rust-lang#31141
@brson
Copy link
Contributor Author

brson commented Mar 23, 2016

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 23, 2016

📌 Commit addde1f has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 24, 2016

⌛ Testing commit addde1f with merge dc1f683...

bors added a commit that referenced this pull request Mar 24, 2016
Make warnings of renamed and removed lints themselves lints

This adds the `renamed_and_removed_lints` warning, defaulting
to the warning level.

Fixes #31141
@alexcrichton
Copy link
Member

This passed on all but android but apparently that bot disappeared so merging manually.

@alexcrichton alexcrichton merged commit addde1f into rust-lang:master Mar 24, 2016
@nrc nrc added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 31, 2016
@pnkfelix
Copy link
Member

compiler team discussion concludes that since actively developed (and warning-free) crates should not themselves cause problems downstream, and thus the only problem here is with older version or abandoned crates, combined with fact that such crates will eventually be painless to pull in (once this PR hits stable in <=12 weeks), means that its not crucial to backport this to beta.

@pnkfelix pnkfelix removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants