Add check on find_best_match_for_name and improve help message for undefined macro #31707
Conversation
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
||
| fn main() { | ||
| k!(); //~ ERROR macro undefined: 'k!' | ||
| //~^ HELP did you mean `kl!`? |
There was a problem hiding this comment.
I'm assuming compiletest can't check help messages? Derp, shouldn't this be checking for the "have you added..." line as well?
There was a problem hiding this comment.
I added it afterward and I'm still waiting an opinion on it. But if it's good as it is right now, then yes.
|
It seems a bit weird that the message would suggest a better name, but if you switch to that one you'll get another error since it wasn't |
|
In #31660, it's solved with |
|
Actually, if the suggested name is the same, we can assume that it's this kind of error. |
GuillaumeGomez
force-pushed
the
macro_name
branch
from
88a0af7 to
eca0ab2
Compare
|
@sfackler: It seems way better like this. What do you think? |
|
Yep, this looks good to me. @bors r+ |
|
📌 Commit eca0ab2 has been approved by |
|
⌛ Testing commit eca0ab2 with merge 4d3eebf... |
I'm wondering if instead of a second help message, a note would be better. I let it up to reviewers.
I'm wondering if instead of a second help message, a note would be better. I let it up to reviewers.
#31660