Skip to content

Improve wording of --target help #31378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Improve wording of --target help #31378

merged 1 commit into from
Feb 4, 2016

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Feb 3, 2016

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

I would personally like to not advertise custom target specs that much, they basically accidentally became stable at 1.0 and if the feature were to land now it would definitely be unstable. Perhaps that part can be elided?

@nagisa
Copy link
Member Author

nagisa commented Feb 3, 2016

accidentally became stable at 1.0 and if the feature were to land now it would definitely be unstable. Perhaps that part can be elided?

Lack of advertisement won’t make the feature go away, will it? Wanting it to be unstable now doesn’t sound like a good motivation for keeping it under wraps to me.

@huonw
Copy link
Member

huonw commented Feb 3, 2016

I would argue that they still are essentially unstable: most people who need them will also be forced to be using nightly for other reasons. The intention was certainly that they are unstable.

Wanting it to be unstable now doesn’t sound like a good motivation for keeping it under wraps to me.

That does actually sound like a pretty good reason to not advertise it: no need to explicitly choose to exacerbate a mistake. This will make life easier if we choose to, for example, phase support out of the stable compiler/deprecate them with warnings.

@nagisa
Copy link
Member Author

nagisa commented Feb 3, 2016

Removed the hints about being able to specify a path.

@alexcrichton
Copy link
Member

@bors: r+ c5c756b

bors added a commit that referenced this pull request Feb 4, 2016
@bors
Copy link
Collaborator

bors commented Feb 4, 2016

⌛ Testing commit c5c756b with merge 9c30f12...

@bors bors merged commit c5c756b into rust-lang:master Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants