Rollup of 5 pull requests #31243
Merged
Rollup of 5 pull requests #31243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Jan 27, 2016
Manishearth
commented
- Successful merges: Improve syntax-index entry for lifetime bounds #30689, Added info on the build system to contributing guide #31186, Fix examples that use missing_docs lint #31219, book: cover UFCS in Syntax Index #31222, Mention that globs import public symbols #31226
- Failed merges:
I recently wrote a blog post on contributing to the Rust compiler which gained some interest. It was mentioned in a comment on Reddit that it would be useful to integrate some of the information from that post to the official contributing guide. This is the start of my efforts to integrate what I wrote with the official guide. This commit adds information on the build system. It is not a complete guide on the build system, but it should be enough to provide a good starting place for those wishing to contribute.
- Tweaked the build system intro paragraph - Added some more configure options & explanations - Added additional make target
The missing_docs lint only applies to public items in public modules, so this example code did not actually generate any warnings or errors.
…klabnik We should have stuff on this in the book somewhere too r? @steveklabnik
I recently wrote a blog post on contributing to the Rust compiler which gained some interest. It was mentioned in a comment on Reddit that it would be useful to integrate some of the information from that post to the official contributing guide. This is the start of my efforts to integrate what I wrote with the official guide. This commit adds information on the build system. It is not a complete guide on the build system, but it should be enough to provide a good starting place for those wishing to contribute.
The missing_docs lint only applies to public items in public modules, so this example code did not actually generate any warnings or errors.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit 5e7dfa7 has been approved by |
|
⌛ Testing commit 5e7dfa7 with merge ba1709e... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors r+ p=10 |
|
📌 Commit 5e7dfa7 has been approved by |
|
@bors retry |
|
⌛ Testing commit 5e7dfa7 with merge 207c7e3... |
|
💔 Test failed - auto-linux-32-nopt-t |
|
@bors retry @alexcrichton buildbot seems to be killing things randomly |
|
⌛ Testing commit 5e7dfa7 with merge 2c71012... |
|
💔 Test failed - auto-linux-64-opt |
|
@bors retry force |
|
@bors force |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.