doc: miscellaneous OpenOptions:append improvements #31093
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -436,19 +436,19 @@ impl OpenOptions { | |||
| /// Note that setting `.write(true).append(true)` has the same effect as | |||
| /// setting only `.append(true)`. | |||
| /// | |||
| /// For most filesystems the operating system guarantees all writes are | |||
| /// For most filesystems, the operating system guarantees all writes to be | |||
There was a problem hiding this comment.
This actually sounds worse to my ear, is there any precedence anywhere?
There was a problem hiding this comment.
An alternative is "the operating system guarantees that all writes are atomic".
|
I like it all except that one thing. |
| /// can be done by concatenating strings before passing them to `write()`, | ||
| /// or using a buffered writer (with a more than adequately sized buffer) | ||
| /// or using a buffered writer (with a more than adequately-sized buffer), |
There was a problem hiding this comment.
I don't believe a - is needed between an adverb and the adjective it modifies ("adequately-sized" doesn't look "correct" to me, in other words). However, this kind of "multi-word adjective" -- "more than adequately sized" -- always feels a little awkward and informal to me in any case. Perhaps "with a buffer of sufficient size" or "with a sufficiently large buffer". (Also, I have no idea what a "more than adequately sized buffer" even is supposed to mean -- surely "adequate" size would be enough, since that is sort of the definition of adequate?)
|
review comments addresed |
|
@bors: r+ rollup thank you! |
|
📌 Commit 012d68a has been approved by |
No description provided.