Skip to content

Moved all VecDeque tests from libcollections to libcollectionstest #30956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2016

Conversation

KiChjang
Copy link
Member

Encountered while I was trying to work on #28518. Please let me know whether this is a correct move.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bluss
Copy link
Member

bluss commented Jan 16, 2016

I found the travis error, search the log for "duplicate definition of value test_drain"

@KiChjang
Copy link
Member Author

Oh, which test should we use for test_drain in that case? There are two tests and I don't know which of them is superior.

@bluss
Copy link
Member

bluss commented Jan 16, 2016

Save both. One is testing drain(..) and the other is testing with different ranges.

@bluss
Copy link
Member

bluss commented Jan 16, 2016

Why do we move these? I don't really know why we have two crates.

@KiChjang
Copy link
Member Author

@gankro said this on IRC:

<Gankro> KiChjang: used to be everything was in libcollections, but libcollectionstest has to pull some stuff out when libcollections gained some langitemss

@KiChjang KiChjang force-pushed the move-tests-to-libcollectionstest branch from 16b3222 to ec9c78e Compare January 16, 2016 15:53
@bluss
Copy link
Member

bluss commented Jan 16, 2016

Ok good

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 16, 2016

📌 Commit ec9c78e has been approved by bluss

@bluss
Copy link
Member

bluss commented Jan 16, 2016

@bors r-

@KiChjang KiChjang force-pushed the move-tests-to-libcollectionstest branch 2 times, most recently from de62d0d to 30aca6e Compare January 16, 2016 17:19
@KiChjang
Copy link
Member Author

test num::tests::test_i32f64 ... ok

test num::tests::test_i32i64 ... ok

<test>:1:62: 1:63 error: macro undefined: 'z!'

<test>:1 fn bogus() {macro_rules! z (() => (3+4));}fn inty() -> i32 { z!() }

                                                                      ^

<test>:1:62: 1:63 help: did you mean `z!`?

error: aborting due to previous error

test ext::expand::tests::macros_cant_escape_fns_test ... ok

test ext::expand::tests::method_arg_hygiene ... ok

test num::tests::test_i8f64 ... ok

test num::tests::test_i8f32 ... ok

test ext::expand::tests::method_arg_hygiene_2 ... ok

<test>:1:59: 1:60 error: macro undefined: 'z!'

<test>:1 mod foo {macro_rules! z (() => (3+4));}fn inty() -> i32 { z!() }

                                                                   ^

<test>:1:59: 1:60 help: did you mean `z!`?

error: aborting due to previous error

test ext::expand::tests::macros_cant_escape_mods_test ... ok

Did I do anything wrong that caused this output?

@KiChjang KiChjang force-pushed the move-tests-to-libcollectionstest branch 3 times, most recently from 8b42f4b to 56c407c Compare January 17, 2016 04:45
use std::iter::Iterator;

#[test]
fn test_zst_push() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a run-pass test, you need a main function and just call this test function manually. We don't use #[test] here.

@KiChjang KiChjang force-pushed the move-tests-to-libcollectionstest branch 2 times, most recently from 2b279c8 to 706e9f5 Compare January 17, 2016 14:21
@bluss
Copy link
Member

bluss commented Jan 18, 2016

@bors r+

Thanks! Notice that there is no notification for new pushes to a PR. You need to put a message here to notify us who are subscribing.

@bors
Copy link
Collaborator

bors commented Jan 18, 2016

📌 Commit 706e9f5 has been approved by bluss

bors added a commit that referenced this pull request Jan 18, 2016
…luss

Encountered while I was trying to work on #28518. Please let me know whether this is a correct move.
@bors
Copy link
Collaborator

bors commented Jan 18, 2016

⌛ Testing commit 706e9f5 with merge a09a604...

@bors bors merged commit 706e9f5 into rust-lang:master Jan 18, 2016
@KiChjang KiChjang deleted the move-tests-to-libcollectionstest branch January 18, 2016 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants