-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Moved all VecDeque tests from libcollections to libcollectionstest #30956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved all VecDeque tests from libcollections to libcollectionstest #30956
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I found the travis error, search the log for "duplicate definition of value |
Oh, which test should we use for |
Save both. One is testing |
Why do we move these? I don't really know why we have two crates. |
@gankro said this on IRC:
|
16b3222
to
ec9c78e
Compare
Ok good @bors r+ |
📌 Commit ec9c78e has been approved by |
@bors r- |
de62d0d
to
30aca6e
Compare
Did I do anything wrong that caused this output? |
8b42f4b
to
56c407c
Compare
use std::iter::Iterator; | ||
|
||
#[test] | ||
fn test_zst_push() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a run-pass test, you need a main function and just call this test function manually. We don't use #[test]
here.
2b279c8
to
706e9f5
Compare
@bors r+ Thanks! Notice that there is no notification for new pushes to a PR. You need to put a message here to notify us who are subscribing. |
📌 Commit 706e9f5 has been approved by |
…luss Encountered while I was trying to work on #28518. Please let me know whether this is a correct move.
Encountered while I was trying to work on #28518. Please let me know whether this is a correct move.