Skip to content

Fixes #30521 and #30627 by adding new snapshots #30643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2015
Merged

Fixes #30521 and #30627 by adding new snapshots #30643

merged 1 commit into from
Dec 30, 2015

Conversation

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

dhuseby pushed a commit that referenced this pull request Dec 30, 2015
Fixes #30521 and #30627 by adding new snapshots
edunham uploaded the snapshots.
@dhuseby dhuseby merged commit 0bd29f8 into rust-lang:master Dec 30, 2015
@dhuseby
Copy link
Author

dhuseby commented Dec 30, 2015

Fixes #30627 too.

@sfackler
Copy link
Member

Was this intentionally merged into master?

@mneumann
Copy link
Contributor

@dhuseby I build the 2015-12-18 snapshot for DragonFly:

http://www.ntecs.de/downloads/rust/rust-stage0-2015-12-18-3391630-dragonfly-x86_64-e74d79488e88ac2de3bd03afd5959d2ae6e2b628.tar.bz2

You only need to patch the SIGSTACKSZ thing, then it builds fine, IIRC.

I also have pushed some patches to https://github.com/rust-lang-nursery/libc, which should help with building more recent versions of Rust (it is broken on libc).

@mneumann
Copy link
Contributor

@dhuseby : If you need help with setting up continuous builds for DragonFly, please let me know.

@dhuseby
Copy link
Author

dhuseby commented Dec 31, 2015

@mneumann i will for sure. so far it seems to be going well.

@mneumann
Copy link
Contributor

@dhuseby : cool! Also feel free to submit a patch to etc/snapshots.txt for DragonFly :)

@dhuseby
Copy link
Author

dhuseby commented Jan 5, 2016

@mneumann I will add the dragonfly snapshot as soon as I can figure out how to get it to build at the last snap rev.

@mneumann
Copy link
Contributor

mneumann commented Jan 5, 2016

@dhuseby : Ok, IIRC I had to patch SIGSTACKSZ constant in rust's libc. I just had to unfold it manually to it's value.

@pnkfelix
Copy link
Member

pnkfelix commented Jan 5, 2016

Did anyone answer @sfackler 's question above? Was there a reason this was directly pushed to master rather than going through bors? (And I don't see any r+'s... ?)

@pnkfelix
Copy link
Member

pnkfelix commented Jan 5, 2016

(having said that, the change seems pretty innocent...)

@dhuseby
Copy link
Author

dhuseby commented Jan 6, 2016

@pnkfelix it's because i'm dumb sometimes and i clicked the "merge" button here in github.

@dhuseby
Copy link
Author

dhuseby commented Jan 6, 2016

@pnkfelix what's the correct way to merge a PR into bors?

@sfackler
Copy link
Member

sfackler commented Jan 6, 2016

"@bors r+"

@dhuseby
Copy link
Author

dhuseby commented Jan 6, 2016

@sfackler thanks!

@alexcrichton
Copy link
Member

Thanks for the snapshots @dhuseby and @mneumann! It looks like @dhuseby's snapshots have been uploaded (by @brson I guess?), but @mneumann it looks like the DragonFly snapshot is still missing and your link unfortunately has a host name that doesn't resolve for me. (in the future as well, could you guys also paste the sha256 with the links as well?)

And yeah @dhuseby just be careful not to merge manually, but no worries!

@mneumann
Copy link
Contributor

@alexcrichton : I pushed the snapshot to @dhuseby 's repo. Then we both opened a pull requests probably at the same time. Next time sha256 👍

@alexcrichton
Copy link
Member

@mneumann cool, thanks! I've uploaded that snapshot now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants