Skip to content

configure: Add --extra-filename flag #30599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2016
Merged

configure: Add --extra-filename flag #30599

merged 1 commit into from
Jan 12, 2016

Conversation

brson
Copy link
Contributor

@brson brson commented Dec 29, 2015

This mixes in additional information into the hash that is
passed to -C extra-filename. It can be used to further distinguish
the standard libraries if they must be installed next to each
other.

Closes #29559

Frankly, I'm not sure if this solves a real problem. It's meant to help with side-by-side and overlapping installations where there are two sets of libs in /usr, but there are other potential issues there as well, including that some of our artifacts don't use this extra-filename munging, and it's not something our installers can support at all.

cc @jauhien Do you still think this helps the Gentoo case?

This mixes in additional information into the hash that is
passed to -C extra-filename. It can be used to further distinguish
the standard libraries if they must be installed next to each
other.

Closes rust-lang#29559
@brson
Copy link
Contributor Author

brson commented Dec 29, 2015

r? @alexcrichton

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@jauhien
Copy link
Contributor

jauhien commented Jan 4, 2016

@brson: thanks, this should help. At least it seems to cover Gentoo use case.

@alexcrichton
Copy link
Member

@bors: r+ ce81f24

@bors
Copy link
Collaborator

bors commented Jan 12, 2016

⌛ Testing commit ce81f24 with merge dedaebd...

bors added a commit that referenced this pull request Jan 12, 2016
This mixes in additional information into the hash that is
passed to -C extra-filename. It can be used to further distinguish
the standard libraries if they must be installed next to each
other.

Closes #29559

Frankly, I'm not sure if this solves a real problem. It's meant to help with side-by-side and overlapping installations where there are two sets of libs in /usr, but there are other potential issues there as well, including that some of our artifacts don't use this extra-filename munging, and it's not something our installers can support at all.

cc @jauhien Do you still think this helps the Gentoo case?
@bors bors merged commit ce81f24 into rust-lang:master Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants