Skip to content

Make runtime function return size_t #30454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2015
Merged

Make runtime function return size_t #30454

merged 2 commits into from
Dec 20, 2015

Conversation

mmcco
Copy link
Contributor

@mmcco mmcco commented Dec 18, 2015

It returns sizeof(dirent_t), so I'm not sure why its return type is int.
It's only used once, and that usage immediately casts it to usize.

It returns sizeof(dirent_t), so I'm not sure why its return type is int.
It's only used once, and that usage immediately casts it to usize.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Apparently this file's use annotations have changed since I last pulled
on my test machine.
@alexcrichton
Copy link
Member

@bors: r+ cf03cee

@bors
Copy link
Collaborator

bors commented Dec 20, 2015

⌛ Testing commit cf03cee with merge 0047d08...

@bors
Copy link
Collaborator

bors commented Dec 20, 2015

💔 Test failed - auto-mac-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Sat, Dec 19, 2015 at 9:28 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/7495


Reply to this email directly or view it on GitHub
#30454 (comment).

bors added a commit that referenced this pull request Dec 20, 2015
It returns sizeof(dirent_t), so I'm not sure why its return type is int.
It's only used once, and that usage immediately casts it to usize.
@bors
Copy link
Collaborator

bors commented Dec 20, 2015

⌛ Testing commit cf03cee with merge d3aec9f...

@bors bors merged commit cf03cee into rust-lang:master Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants