Ensure two SystemTimes are equal when nanos add to exactly 1B

[sgrif]

Currently if you add a duration which should lead to 0 nanos and 1
additional second, we end up with no additional seconds, and 1000000000
nanos.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[sfackler]

Some tidy errors: https://travis-ci.org/rust-lang/rust/builds/94495543#L509

Looks good to me other than that though.

[alexcrichton]

Gah oops, thanks @sgrif!

[sgrif]

Made tidy!

[alexcrichton]

@bors: r+ a59cd36

[bors]

⌛ Testing commit a59cd36 with merge 354f74e...

[bors]

💔 Test failed - auto-mac-64-nopt-t

[sgrif]

Ah right, the added test is invalid on mac/ios, as it doesn't have nanosecond precision. Does it make sense to just cfg it out on that platform?

[sgrif]

Tests should be passing on all platforms now

[sfackler]

@bors r+

[bors]

📌 Commit 5dbc373 has been approved by sfackler

[bors]

⌛ Testing commit 5dbc373 with merge 2a33a32...

[bors]

💔 Test failed - auto-mac-64-nopt-t

[sgrif]

Well, there is still a completely valid bug here on Mac. I will fix in the
morning.

On Thu, Dec 3, 2015, 6:42 PM bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/7307

—

Reply to this email directly or view it on GitHub
#30173 (comment).

[alexcrichton]

I think the same >= (instead of >) test may be necessary here as well.

[sgrif]

Updated.

[alexcrichton]

@bors: r+ 0747142

[bors]

⌛ Testing commit 0747142 with merge 55a4e05...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt