Skip to content

Fix docs for TcpListener::bind #30052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2015
Merged

Fix docs for TcpListener::bind #30052

merged 1 commit into from
Nov 25, 2015

Conversation

Ryman
Copy link
Contributor

@Ryman Ryman commented Nov 25, 2015

socket_addr was renamed to local_addr in 1.0beta.

See: f798674

r? @steveklabnik

@@ -234,7 +234,7 @@ impl TcpListener {
///
/// Binding with a port number of 0 will request that the OS assigns a port
/// to this listener. The port allocated can be queried via the
/// `socket_addr` function.
/// `local_addr` function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to "local_addr method"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated.

`socket_addr` was renamed to `local_addr` in 1.0beta.

See: f798674
@apasel422
Copy link
Contributor

@bors: r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 25, 2015

📌 Commit add5054 has been approved by apasel422

bors added a commit that referenced this pull request Nov 25, 2015
`socket_addr` was renamed to `local_addr` in 1.0beta.

See: f798674

r? @steveklabnik
@bors
Copy link
Collaborator

bors commented Nov 25, 2015

⌛ Testing commit add5054 with merge e3dfb2c...

@bors bors merged commit add5054 into rust-lang:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants