Semi-fix --libdir installs #29845
Merged
Semi-fix --libdir installs #29845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 16159979d45b6fb4b6bee98e808617ce6d53429a |
|
⌛ Testing commit 1615997 with merge 5c54dfa... |
|
💔 Test failed - auto-win-msvc-64-opt |
This is to handle the case where CFG_LIBDIR is not a direct child of CFG_PREFIX (in other words, where CFG_LIBDIR_RELATIVE has more than one component).
|
I suppose it is more likely to work if the library path is not defined inside an "if not windows" section. Try this. |
|
@bors: r+ On Sunday, November 15, 2015, wthrowe [email protected] wrote:
|
|
📌 Commit 2b98d4f has been approved by |
bors
added a commit
that referenced
this pull request
Nov 16, 2015
This should get `--libdir` working as well as it was a couple of weeks ago. (That is, it still rewrites paths incorrectly but it no longer fails during `make install`.) Fixes gentoo/gentoo-rust#28 and gentoo/gentoo-rust#29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get
--libdirworking as well as it was a couple of weeks ago. (That is, it still rewrites paths incorrectly but it no longer fails duringmake install.)Fixes gentoo/gentoo-rust#28 and gentoo/gentoo-rust#29.