Skip to content

statics in match arm: compile with -g #29700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Nov 8, 2015

Currently, this ICEs. See #29696. Also removes duplicate test case.

Currently, this ICEs. See rust-lang#29696. Also removes duplicate test case.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa
Copy link
Member

nagisa commented Nov 8, 2015

Do not remove the whole test, ignore it instead.

EDIT: Ah, I see, its a duplicate.

@tamird
Copy link
Contributor Author

tamird commented Nov 8, 2015

Why? It's duplicating things that are already tested in match-arm-statics.

@alexcrichton
Copy link
Member

@bors: r+ d8f82a6

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

⌛ Testing commit d8f82a6 with merge 0482423...

@bors
Copy link
Collaborator

bors commented Nov 10, 2015

💔 Test failed - auto-mac-64-opt

@tamird
Copy link
Contributor Author

tamird commented Nov 10, 2015

This failure is expected since this is still a bug.

@alexcrichton
Copy link
Member

Oh, in that case I'm gonna close this for now and we can perhaps add this once the bug is fixed!

@tamird
Copy link
Contributor Author

tamird commented Jan 30, 2017

@alexcrichton this passes now; can you reopen?

Probably not since I've pushed the branch; resubmitted.

bors added a commit that referenced this pull request Feb 2, 2017
statics in match arm: compile with -g

Resubmission of #29700.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants