std: Base Hash for Path on its iterator #29456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
A definite pitfall of derive! I wonder if we could lint for cases where you've given a custom implementation of @bors: r+ |
|
📌 Commit 3a07518 has been approved by |
|
⌛ Testing commit 3a07518 with merge 7216ea7... |
|
💔 Test failed - auto-win-gnu-64-opt |
Almost all operations on Path are based on the components iterator in one form or another to handle equivalent paths. The `Hash` implementations, however, mistakenly just went straight to the underlying `OsStr`, causing these equivalent paths to not get merged together. This commit updates the `Hash` implementation to also be based on the iterator which should ensure that if two paths are equal they hash to the same thing. cc rust-lang#29008, but doesn't close it
alexcrichton
force-pushed
the
path-hash
branch
from
3a07518 to
d2dd700
Compare
|
⌛ Testing commit d2dd700 with merge a1fd944... |
bors
added a commit
that referenced
this pull request
Nov 2, 2015
Almost all operations on Path are based on the components iterator in one form or another to handle equivalent paths. The `Hash` implementations, however, mistakenly just went straight to the underlying `OsStr`, causing these equivalent paths to not get merged together. This commit updates the `Hash` implementation to also be based on the iterator which should ensure that if two paths are equal they hash to the same thing. cc #29008, but doesn't close it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all operations on Path are based on the components iterator in one form
or another to handle equivalent paths. The
Hashimplementations, however,mistakenly just went straight to the underlying
OsStr, causing theseequivalent paths to not get merged together.
This commit updates the
Hashimplementation to also be based on the iteratorwhich should ensure that if two paths are equal they hash to the same thing.
cc #29008, but doesn't close it