Comment on shadowing with patterns #28893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -23,6 +23,31 @@ match x { | |||
|
|
|||
| This prints `one`. | |||
|
|
|||
| There’s one pitfall with patterns: like anything that introduces a new binding, | |||
There was a problem hiding this comment.
I wonder if it's worth having a section on shadowing? It is interesting to point out that Rust typically allows shadowing, and patterns are just a special case.
It's ALSO interesting (perhaps) to point out that you cannot shadow a constant or enum variant name.
There was a problem hiding this comment.
We talk about it in the variable bindings section, but this is a question that people ask about with patterns specifically, so I felt it was worth re-calling it out.
|
@bors r+ rollup |
|
📌 Commit bbc2056 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 8, 2015
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 8, 2015
bors
added a commit
that referenced
this pull request
Oct 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28687