Remove a needless memset() from the runtime #28407
Conversation
…e len is actually one more than the length of argv[0]. However, this is precarious and should probably be replaced with more robust logic.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Can you update the PR's description? Only the body of the message and not the title will be in the git log for the merge, so it's awkward to have only a half sentence. |
…e len is actually one more than the length of argv[0]. However, this is precarious and should probably be replaced with more robust logic.
mmcco
changed the title
It's okay that we don't append NUL because len is actually one more than the length of argv[0]. However, this is precarious and should probably be replaced with more robust logic.