-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update README.md #28042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #28042
Conversation
Encountered an issue going through the guide for installing the `mingw` toolchain on Windows with msys2, after some googling I found the [solution](msys2/MSYS2-packages#163 (comment)) and thought it would be good to update the README so people don't get frustrated. :)
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Hey @Jake-Shadle ! While this might be helpful, I'm also not sure we want to be including Pacman help in our README. @brson has kind of been the "Guardian of the README" lately. Brian, what do you think? |
Cluttering the README might be bad, but as far as I can tell, any Windows user who tried the current README would fail on that step, which isn't a great user experience. Maybe just a link to the issue mentioned in this PR would suffice? eg.
|
@Jake-Shadle what would you think of simply adding the update command as the first step, so assume they are going to have the correct packages and not run into this error? Like
|
@brson I think you can just do |
Folded in suggestion from @brson to simply put the mirror update step in the regular set of tool chain install commands.
@brson took your suggestion and added the commands with a comment in the existing code block, nice and succinct! |
@Jake-Shadle What do you think of @jonas-schievink's suggestion to just write |
Use suggested composite command instead of 2 separate commands.
@brson Heh, fair enough, it is the main readme of the language, how is it now? |
@bors: r+ rollup |
📌 Commit 7ab8ed8 has been approved by |
Encountered an issue with `pacman` while going through the guide for installing the `mingw` toolchain on Windows with `msys2`, after some googling I found the [solution](msys2/MSYS2-packages#163 (comment)). I thought it would be good to update the README so people don't get frustrated. 😃 r? @steveklabnik
Encountered an issue with
pacman
while going through the guide for installing themingw
toolchain on Windows withmsys2
, after some googling I found the solution.I thought it would be good to update the README so people don't get frustrated. 😃
r? @steveklabnik