Skip to content

A few small GEPi/fat pointer related cleanups #27981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2015
Merged

A few small GEPi/fat pointer related cleanups #27981

merged 3 commits into from
Aug 25, 2015

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Aug 24, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@Kimundi
Copy link
Member

Kimundi commented Aug 24, 2015

I feel like get_meta() or get_dst_meta() is more self describing than get_extra().

dotdash added 3 commits August 24, 2015 23:39
@dotdash
Rename get_len() to get_meta()
d80ff12 
The functions is useful for all kinds of fat pointers, but get_len()
just feels so wrong for trait object fat pointers. Let's use get_meta()
because that's rather neutral.
@dotdash
Use get_dataptr() and get_meta() where appropriate
110a34c
@dotdash
Use StructGEP instead of GEPi where appropriate
5d9c250 
StructGEP seems clearer and probably does an even better job of the
micro-optimization that we have in GEPi.
@brson
Copy link
Contributor

brson commented Aug 25, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 25, 2015

📌 Commit 5d9c250 has been approved by brson

@bors
Copy link
Collaborator

bors commented Aug 25, 2015

⌛ Testing commit 5d9c250 with merge 5c630a6...

bors added a commit that referenced this pull request Aug 25, 2015
@bors
Auto merge of #27981 - dotdash:gepi, r=brson
5c630a6
@bors
Copy link
Collaborator

bors commented Aug 25, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 5d9c250 into rust-lang:master Aug 25, 2015
@dotdash dotdash deleted the gepi branch January 15, 2016 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dotdash @rust-highfive @Kimundi @brson @bors