Skip to content

Add E0323, E0324, E0325, E0369 and E0390 errors explanation #27586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 23, 2015

Conversation

GuillaumeGomez
Copy link
Member

Part of #24407.

This PR doesn't have code example since I didn't find how to raise it. If someone finds a code which does, please say it !

cc @pnkfelix
cc @eddyb
r? @Manishearth

@Manishearth
Copy link
Member

I don't think either of the suggestions are correct

@GuillaumeGomez
Copy link
Member Author

Me neither. I just opened it, I'll see tomorrow for the explanation.

@arielb1
Copy link
Contributor

arielb1 commented Aug 9, 2015

@GuillaumeGomez

fn undefined<T>() -> T { unreachable!() }
fn main() {
    match undefined() {
        &ref x => {}
    }
}

No, actually this yields E0101.

@GuillaumeGomez
Copy link
Member Author

@arielb1: nice try however !

It reminds me that I still have to update the error explanation...

@GuillaumeGomez GuillaumeGomez changed the title Add E0103 error explanation Add E0103 and E0425 error explanations Aug 10, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0103 and E0425 error explanations Add E0103 and E0425 errors explanation Aug 10, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0103 and E0425 errors explanation Add E0103, E0323 and E0425 errors explanation Aug 12, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0103, E0323 and E0425 errors explanation Add E0103, E0323, E0324 and E0425 errors explanation Aug 12, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0103, E0323, E0324 and E0425 errors explanation Add E0103, E0323, E0324, E0325 and E0425 errors explanation Aug 12, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0103, E0323, E0324, E0325 and E0425 errors explanation Add E0103, E0323, E0324, E0325, E0369 and E0425 errors explanation Aug 12, 2015
@bors
Copy link
Collaborator

bors commented Aug 12, 2015

☔ The latest upstream changes (presumably #27688) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez GuillaumeGomez changed the title Add E0103, E0323, E0324, E0325, E0369 and E0425 errors explanation Add E0103, E0323, E0324, E0325 and E0369 errors explanation Aug 16, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0103, E0323, E0324, E0325 and E0369 errors explanation Add E0103, E0323, E0324, E0325, E0369 and E0390 errors explanation Aug 17, 2015
@GuillaumeGomez
Copy link
Member Author

I need a review here (mostly on E0103 and E0390).
cc @Manishearth
cc @pnkfelix
cc @michaelsproul
cc @arielb1

@@ -1278,6 +1278,15 @@ fn main() {
```
"##,

E0103: r##"
You hit this error because the compiler the compiler lacks information
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the compiler the compiler" :)

```

To fix this error, please verify you didn't misspell the associated type name
and that your trait item implementation corresponds to the trait definition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that the associated type name wasn't misspelled and your implementation corresponds to the trait definition.

@@ -2617,6 +2774,28 @@ For more information see the [opt-in builtin traits RFC](https://github.com/rust
-lang/rfcs/blob/master/text/0019-opt-in-builtin-traits.md).
"##,

E0390: r##"
You tried to implement methods for a mutable raw pointer (*mut T). Erroneous
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is actually for implementing on any primitive, sorry.

In this case, using a trait to impl a method is the better suggestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"only a single inherent implementation marked with `#[lang = \"{}\"]` \

@GuillaumeGomez GuillaumeGomez changed the title Add E0103, E0323, E0324, E0325, E0369 and E0390 errors explanation Add E0323, E0324, E0325, E0369 and E0390 errors explanation Aug 22, 2015
@Manishearth
Copy link
Member

@bors r+ rollup

r=eddyb for my commit

@bors
Copy link
Collaborator

bors commented Aug 22, 2015

📌 Commit 0642d99 has been approved by Manishearth

bors added a commit that referenced this pull request Aug 23, 2015
Part of #24407.

This PR doesn't have code example since I didn't find how to raise it. If someone finds a code which does, please say it !

cc @pnkfelix
cc @eddyb
r? @Manishearth
@bors
Copy link
Collaborator

bors commented Aug 23, 2015

⌛ Testing commit 0642d99 with merge 0e71bda...

@bors bors merged commit 0642d99 into rust-lang:master Aug 23, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-2 branch August 24, 2015 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants