std: Deprecate extra TcpStream/UdpSocket methods #27368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are all covered by [RFC 1158] and are currently all available on stable Rust via the [`net2` crate][net2] on crates.io. This commit does not touch the timeout related functions as they're still waiting on `Duration` which is unstable anyway, so punting in favor of the `net2` crate wouldn't buy much. [RFC 1158]: rust-lang/rfcs#1158 [net2]: http://crates.io/crates/net2 Specifically, this commit deprecates: * TcpStream::set_nodelay * TcpStream::set_keepalive * UdpSocket::set_broadcast * UdpSocket::set_multicast_loop * UdpSocket::join_multicast * UdpSocket::set_multicast_time_to_live * UdpSocket::set_time_to_live
alexcrichton
added
the
T-libs-api
|
r? @aturon |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
deprecate-net-methods
branch
from
7196b3e to
798ce50
Compare
|
I'm a bit puzzled by the rationale here: why deprecate these when the plan is, ultimately, to stabilize them? |
|
Almost all of these functions will have their signatures changed anyway, and I figured it'd be good to encourage any current users to try out the |
|
Ah OK, I had forgotten that there were signature changes as well. In that case: @bors: r+ |
|
📌 Commit 798ce50 has been approved by |
|
⌛ Testing commit 798ce50 with merge 823f4fc... |
bors
added a commit
that referenced
this pull request
Jul 29, 2015
These methods are all covered by [RFC 1158] and are currently all available on stable Rust via the [`net2` crate][net2] on crates.io. This commit does not touch the timeout related functions as they're still waiting on `Duration` which is unstable anyway, so punting in favor of the `net2` crate wouldn't buy much. [RFC 1158]: rust-lang/rfcs#1158 [net2]: http://crates.io/crates/net2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are all covered by RFC 1158 and are currently all available on
stable Rust via the
net2crate on crates.io. This commit does nottouch the timeout related functions as they're still waiting on
Durationwhichis unstable anyway, so punting in favor of the
net2crate wouldn't buy much.