Skip to content

Avoid creating basic blocks for empty cleanup scopes #27221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2015

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Jul 22, 2015

When compiling libsyntax this removes about 30k basic blocks that only
contain a single unconditional jump and reduces the peak memory usage by
about 10MB (from 681MB down to 671MB).

When compiling libsyntax this removes about 30k basic blocks that only
contain a single unconditional jump and reduces the peak memory usage by
about 10MB (from 681MB down to 671MB).
@rust-highfive
Copy link
Contributor

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@luqmana
Copy link
Member

luqmana commented Jul 22, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 22, 2015

📌 Commit a66af87 has been approved by luqmana

@bors
Copy link
Collaborator

bors commented Jul 23, 2015

⌛ Testing commit a66af87 with merge facb74b...

@bors
Copy link
Collaborator

bors commented Jul 23, 2015

💔 Test failed - auto-mac-64-nopt-t

@dotdash
Copy link
Contributor Author

dotdash commented Jul 23, 2015

@bors retry

@bors
Copy link
Collaborator

bors commented Jul 23, 2015

⌛ Testing commit a66af87 with merge 7911d99...

bors added a commit that referenced this pull request Jul 23, 2015
When compiling libsyntax this removes about 30k basic blocks that only
contain a single unconditional jump and reduces the peak memory usage by
about 10MB (from 681MB down to 671MB).
@bors bors merged commit a66af87 into rust-lang:master Jul 23, 2015
@dotdash dotdash deleted the no_empty_clean branch July 27, 2015 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants