Fixed some occurrences of 'if' being spelled 'iff' #26878
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I've been told that "iff" is short for "if and only if" (Wikipedia confirms this). |
|
Ahh, well I feel dumb then. Well TIL I guess. |
|
I think use of "iff" in API docs should probably be replaced with "if, and only if,", unless it's in a highly technical section that already discusses things in mathematical terms (like a proof of some algorithm's correctness). |
|
@tomjakubowski agreed. Almost all of these are not in documentation, but I would accept a patch that changed it to be more explicit in user-facing stuff |
|
@steveklabnik Okay, then I've undone the "iff" -> 'if" from the last commit and the rustdoc comments that had "iff" are renamed to "if and only if" |
|
@bors r=dad8cd1 rollup |
|
📌 Commit dad8cd1 has been approved by |
|
r=pnkfelix |
|
@bors r=pnkfelix |
|
📌 Commit dad8cd1 has been approved by |
|
⌛ Testing commit dad8cd1 with merge 8b57215... |
|
💔 Test failed - auto-linux-64-opt |
|
@bors: retry |
I noticed in docs, specifically http://doc.rust-lang.org/std/primitive.u8.html#method.is_power_of_two, that it was like this, and it was apparently in multiple places too. Didn't change any occurrences through the cross-depo things. There's a lot in /src/llvm/ for instance, but I'm not confident on how to go about sending fixes for those, so this is just what's in the base rust depo. r? @steveklabnik
|
|
I noticed in docs, specifically http://doc.rust-lang.org/std/primitive.u8.html#method.is_power_of_two, that it was like this, and it was apparently in multiple places too.
Didn't change any occurrences through the cross-depo things. There's a lot in /src/llvm/ for instance, but I'm not confident on how to go about sending fixes for those, so this is just what's in the base rust depo.
r? @steveklabnik