Fix incorrect warning about unused repr attributes. #26663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for the PR! Could you also add a test for this as well? |
| #[repr(C)] | ||
| pub struct Bar; | ||
|
|
||
| fn main() { } |
There was a problem hiding this comment.
There should be a newline at the end of the file.
|
@bors r+ |
|
📌 Commit e8fe55f has been approved by |
bors
added a commit
that referenced
this pull request
Jun 30, 2015
Fixes #26646. Loops over all `#[repr(..)]` attributes instead of stopping at the first one to make sure they are all marked as used. Previously it stopped after the first `#[repr(C)]` was found causing all other attributes to be skipped by the linter.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26646.
Loops over all
#[repr(..)]attributes instead of stopping at the first one to make sure they are all marked as used. Previously it stopped after the first#[repr(C)]was found causing all other attributes to be skipped by the linter.