Clean up junk & add caching to stability #25785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| self.instantiate_default_methods(local_def(item.id), | ||
| if let Some(trait_ref) = ty::impl_trait_ref(self.crate_context.tcx, | ||
| local_def(item.id)) { self.instantiate_default_methods(local_def(item.id), |
There was a problem hiding this comment.
Looks like the newline got eaten (found by Travis).
|
This is very nice cleanup, thanks! r=me with nit fixed |
|
@eddyb: fixed |
|
For real this time |
|
@bors r+ |
|
📌 Commit 0ec3183 has been approved by |
bors
added a commit
that referenced
this pull request
May 26, 2015
The caching essentially eliminates "stability checking" time (my attempt to clean-up junk got tangled up with stability, so I added the caching while I was at it). r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caching essentially eliminates "stability checking" time (my attempt to clean-up junk got tangled up with stability, so I added the caching while I was at it).
r? @eddyb