Guard against overflow in codemap::span_to_lines.
#24976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There a number of recent issues that report the bug here. See e.g. rust-lang#24761 and rust-lang#24954. This change does *not* fix them; it just makes the assert more immediate (and also injects a more conservative check, in that we are also checking that the files match up). So, this does not directly fix any bugs, and is expected ot actually inject new ICE's. But those will all represent latent bugs that need fixing.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 194a6af has been approved by |
|
⌛ Testing commit 194a6af with merge 6631de0... |
|
💔 Test failed - auto-mac-64-opt |
|
heh, looks like I was a little too optimistic about whether our own test suite would tickle the ICE's that this injects. I'll work on addressing those. |
|
(closing; I'll put up a different PR later that is a bit more aggressive, e.g. by switching to a |
bors
added a commit
that referenced
this pull request
May 7, 2015
Guard against overflow in `codemap::span_to_lines`. (Revised/expanded version of PR #24976) Make `span_to_lines` to return a `Result`. In `diagnostic`, catch `Err` from `span_to_lines` and print `"(unprintable span)"` instead. ---- There a number of recent issues that report the bug here. See e.g. #24761 and #24954. This change *might* fix them. However, that is *not* its main goal. The main goals are: 1. Make it possible for callers to recover from an error here, and 2. Insert a more conservative check, in that we are also checking that the files match up. ---- As a drive-by, fix #24997 , which was causing my attempts to `make check-stage1` on an `--enable-debug` build to fail.
bors
added a commit
that referenced
this pull request
May 7, 2015
Guard against overflow in `codemap::span_to_lines`. (Revised/expanded version of PR #24976) Make `span_to_lines` to return a `Result`. In `diagnostic`, catch `Err` from `span_to_lines` and print `"(unprintable span)"` instead. ---- There a number of recent issues that report the bug here. See e.g. #24761 and #24954. This change *might* fix them. However, that is *not* its main goal. The main goals are: 1. Make it possible for callers to recover from an error here, and 2. Insert a more conservative check, in that we are also checking that the files match up. ---- As a drive-by, fix #24997 , which was causing my attempts to `make check-stage1` on an `--enable-debug` build to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against overflow in
codemap::span_to_lines.There a number of recent issues that report the bug here. See e.g. #24761 and #24954.
This change does not fix them; it just makes the assert more immediate (and also injects a more conservative check, in that we are also checking that the files match up).
So, this does not directly fix any bugs, and is expected to actually inject new ICE's. But those will all represent latent bugs that need fixing.