Rolling up PRs in the queue #24433
Merged
Rolling up PRs in the queue #24433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it doesn't utilize the parameter, it's not very idiomatic since it could just use the `Result::or` method. So this changes the example to utilize the parameter. As far as I can tell, all the numbers in this example are completely arbitrary.
The meaning of each variant of this enum was somewhat ambiguous and it's uncler that we wouldn't even want to add more enumeration values in the future. As a result this error has been altered to instead become an opaque structure. Learning about the "first invalid byte index" is still an unstable feature, but the type itself is now stable.
It was mistakenly calling it with "foo.txt" instead of "txt". I've also added an assert.
It looks like `from_vec` was subsumed by new at some point, but the documentation still refers to it as `from_vec`. This updates the documentation for `from_vec_unchecked` so that it properly says that it's the unchecked version of `new`. Also, from_vec_unchecked requires a actual Vec<u8> while new can take anything that is Into<Vec<u8>>, so I also mention that in the documentation.
Only '?' should do that. Fixes rust-lang#24289.
Issue rust-lang#24292 demonstrates that the `scoped` API as currently offered can be memory-unsafe: the `JoinGuard` can be moved into a context that will fail to execute destructors prior to the stack frame being popped (for example, by creating an `Rc` cycle). This commit reverts the APIs to `unstable` status while a long-term solution is worked out. (There are several possible ways to address this issue; it's not a fundamental problem with the `scoped` idea, but rather an indication that Rust doesn't currently provide a good way to ensure that destructors are run within a particular stack frame.) [breaking-change]
- Adds two more functions for broadcast address and special address classes reserved for documentation - Modifies the globally routable IP check to include these new functions Fixes rust-lang#24314
`thread::spawn` was previously restricted to closures that return `()`, which limited the utility of joining on a spawned thread. However, there is no reason for this restriction, and this commit allows arbitrary return types. Since it introduces a type parameter to `JoinHandle`, it's technically a: [breaking-change] However, no code is actually expected to break.
Feel silly because it's just one thing but it was bothering me that the documentation tells you what you're not going to learn now instead of linking to the item in question. Am total noob pls assist, where is power button. :)
It's no longer a community based project. Also, Rust for Rubyists is deprecated at this point, so we shouldn't link to it anymore.
The two-step command left off the nightly flag :frown: Thanks @mdinger
Not sure if `From<Error>` is the correct way to reference that trait (maybe `From<E: Error>`?)
This commit entirely removes the old I/O, path, and rand modules. All functionality has been deprecated and unstable for quite some time now!
Just bind the relevant platform-specific functions we should probably be calling anyway.
|
@bors: force |
|
⌛ Testing commit d3da5a7 with merge 0478888... |
|
⌛ Testing commit 5e1812d with merge ec37732... |
|
💔 Test failed - auto-mac-64-opt |
|
⌛ Testing commit 145cebb with merge 465f8f3... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: r+ e053571 force |
|
⌛ Testing commit e053571 with merge c9d065d... |
|
💔 Test failed - auto-linux-64-opt |
|
@bors: retry force On Tue, Apr 14, 2015 at 5:52 PM, bors [email protected] wrote:
|
|
⌛ Testing commit e053571 with merge 16e1fce... |
bors
added a commit
that referenced
this pull request
Apr 15, 2015
This was referenced Apr 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.