Rollup of 7 pull requests #24349
Merged
Rollup of 7 pull requests #24349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Apr 12, 2015
Manishearth
commented
- Successful merges: Added small note when two different closures fail typechecking. #24072, Simplify iterator logic for Fuse #24233, Add tests for #16602 #24321, Remove regex module from libunicode #24339, Updated dead link in Traits chapter #24341, Fixed with_extension documentation bug #24342, Documentary fix #24347
- Failed merges:
Docs meant that Option is returned though the function returns Result.
…pnkfelix Also fixed bug calling .note() instead of .help() See rust-lang#24036
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=20 force |
|
📌 Commit 39c6c7b has been approved by |
|
⌛ Testing commit 39c6c7b with merge a91650c... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: r+ p=20 force |
|
📌 Commit affc077 has been approved by |
|
⌛ Testing commit affc077 with merge ced4228... |
The "static and dynamic dispatch" chapter seems to no longer exist but there is a dead link from the Traits chapter pointing to it. Have changed the link to point to "Trait Objects" which covers static and dynamic dispatch.
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: r+ p=20 force |
|
📌 Commit dd82599 has been approved by |
|
⌛ Testing commit dd82599 with merge 5080b9f... |
bors
added a commit
that referenced
this pull request
Apr 12, 2015
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: r+ p=20 force |
|
📌 Commit 72dc6fc has been approved by |
bors
added a commit
that referenced
this pull request
Apr 12, 2015
Docs meant that ParseIntError is returned though the function returns ParseFloatError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.