Revert "Revert "std: Re-enable at_exit()"" #23267

alexcrichton · 2015-03-11T00:14:19Z

This reverts commit aec67c2.

Closes #20012

This is temporarily rebased on #23245 as it would otherwise conflict, the last commit is the only one relevant to this PR though.

alexcrichton · 2015-03-11T00:14:26Z

r? @aturon

rust-highfive · 2015-03-11T00:14:34Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-03-11T00:15:44Z

I should also point out that this has bounced many times on windows previously, but I've run it through my own windows VM and it passed through try with only win32 timing out (this has been seen before as well). Not to say that it'll actually pass though...

brson · 2015-03-11T00:24:07Z

@bors: r+

bors · 2015-03-11T00:24:08Z

~~@bors r=brson 2d60fcb~~

This reverts commit aec67c2. Closes rust-lang#20012 This is temporarily rebased on rust-lang#23245 as it would otherwise conflict, the last commit is the only one relevant to this PR though.

bors · 2015-03-12T10:44:09Z

⌛ Testing commit 2d60fcb with merge d782c29...

bors · 2015-03-12T11:03:18Z

💔 Test failed - auto-mac-64-nopt-t

Manishearth · 2015-03-12T11:18:34Z

/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:87:5: 87:26 error: unused import, #[deny(unused_imports)] on by default
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:87 use os::unix::prelude::*;
                                                                                                          ^~~~~~~~~~~~~~~~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:89:17: 89:24 error: unused import, #[deny(unused_imports)] on by default
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:89 use ffi::{CStr, AsOsStr};
                                                                                                                      ^~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:61:13: 65:14 error: unnecessary `unsafe` block, #[deny(unused_unsafe)] on by default
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:61             unsafe {
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:62                 let info = info();
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:63                 let diff = self.t as i64 - other.t as i64;
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:64                 Duration::nanoseconds(diff * info.numer as i64 / info.denom as i64)
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:65             }
error: aborting due to 3 previous errors
make: *** [x86_64-apple-darwin/stage1/lib/rustlib/x86_64-apple-darwin/lib/stamp.std] Error 101

alexcrichton · 2015-03-12T19:35:31Z

@bors: r=aturon cceac1b

alexcrichton · 2015-03-12T20:14:41Z

@bors: r=aturon ce4d068

bors · 2015-03-12T22:45:08Z

⌛ Testing commit ce4d068 with merge e147106...

bors · 2015-03-13T01:00:00Z

💔 Test failed - auto-win-64-opt

alexcrichton · 2015-03-13T01:37:23Z

@bors: retry

bors · 2015-03-13T03:31:23Z

⌛ Testing commit ce4d068 with merge 4a5101a...

This reverts commit aec67c2. Closes #20012 This is temporarily rebased on #23245 as it would otherwise conflict, the last commit is the only one relevant to this PR though.

bors · 2015-03-13T05:33:15Z

💔 Test failed - auto-win-64-opt

alexcrichton · 2015-03-13T05:40:05Z

@bors: retry

On Thu, Mar 12, 2015 at 10:33 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-64-opt
http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/2549

—
Reply to this email directly or view it on GitHub
#23267 (comment).

bors · 2015-03-13T05:53:21Z

⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

bors · 2015-03-13T08:01:26Z

💔 Test failed - auto-win-64-nopt-t

Manishearth · 2015-03-13T08:28:58Z

@bors: retry

bors · 2015-03-13T09:36:47Z

⚡ Previous build results for auto-linux-64-nopt-t, auto-linux-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

bors · 2015-03-14T01:04:36Z

💔 Test failed - auto-win-64-opt

Manishearth · 2015-03-14T13:54:52Z

@bors: retry

shakes fist at buildbot

bors · 2015-03-14T14:58:54Z

⌛ Testing commit a793f87 with merge f9c6454...

bors · 2015-03-14T16:59:05Z

💔 Test failed - auto-win-32-opt

sfackler · 2015-03-15T00:17:39Z

Seems like it's probably a legit problem at this point.

Manishearth · 2015-03-15T00:32:20Z

Yeah, probably.

alexcrichton · 2015-03-18T20:27:16Z

@bors: r=aturon 9c18736

(btw I would not recommend putting this PR into a rollup)

Manishearth · 2015-03-19T02:43:07Z

@bors: p=1

(not included in rollup, might as well prioritize it over the other rolled up PRs)

bors · 2015-03-19T03:02:10Z

⌛ Testing commit 9c18736 with merge 197e3fc...

bors · 2015-03-19T03:05:38Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2015-03-19T03:16:24Z

⌛ Testing commit 9c18736 with merge 254a7b5...

bors · 2015-03-19T03:19:06Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2015-03-19T05:56:37Z

⌛ Testing commit 9c18736 with merge b733a42...

bors · 2015-03-19T08:12:30Z

💔 Test failed - auto-win-32-opt

This reverts commit aec67c2.

alexcrichton · 2015-03-20T17:56:58Z

@bors: r=aturon 1cc9718

bors · 2015-03-20T20:19:43Z

⌛ Testing commit 1cc9718 with merge 68d6941...

This reverts commit aec67c2. Closes #20012 This is temporarily rebased on #23245 as it would otherwise conflict, the last commit is the only one relevant to this PR though.

bors · 2015-03-20T22:56:38Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

alexcrichton · 2015-03-20T22:57:31Z

40th time's the charm!

rust-highfive assigned brson Mar 11, 2015

rust-highfive assigned aturon and unassigned brson Mar 11, 2015

alexcrichton force-pushed the issue-20012 branch from 2d60fcb to cceac1b Compare March 12, 2015 19:35

alexcrichton force-pushed the issue-20012 branch from cceac1b to ce4d068 Compare March 12, 2015 20:14

alexcrichton mentioned this pull request Mar 13, 2015

Use new io in print and println macroses #23206

Merged

alexcrichton force-pushed the issue-20012 branch from a793f87 to 9c18736 Compare March 18, 2015 20:26

alexcrichton force-pushed the issue-20012 branch from 9c18736 to fc48640 Compare March 20, 2015 16:50

Revert "Revert "std: Re-enable at_exit()""

1cc9718

This reverts commit aec67c2.

alexcrichton force-pushed the issue-20012 branch from fc48640 to 1cc9718 Compare March 20, 2015 17:56

bors merged commit 1cc9718 into rust-lang:master Mar 20, 2015

alexcrichton deleted the issue-20012 branch March 20, 2015 22:57

Revert "Revert "std: Re-enable at_exit()"" #23267

Revert "Revert "std: Re-enable at_exit()"" #23267

Conversation

alexcrichton commented Mar 11, 2015

alexcrichton commented Mar 11, 2015

rust-highfive commented Mar 11, 2015

alexcrichton commented Mar 11, 2015

brson commented Mar 11, 2015

bors commented Mar 11, 2015

bors commented Mar 12, 2015

bors commented Mar 12, 2015

Manishearth commented Mar 12, 2015

alexcrichton commented Mar 12, 2015

alexcrichton commented Mar 12, 2015

bors commented Mar 12, 2015

bors commented Mar 13, 2015

alexcrichton commented Mar 13, 2015

bors commented Mar 13, 2015

bors commented Mar 13, 2015

alexcrichton commented Mar 13, 2015

bors commented Mar 13, 2015

bors commented Mar 13, 2015

Manishearth commented Mar 13, 2015

bors commented Mar 13, 2015

bors commented Mar 14, 2015

Manishearth commented Mar 14, 2015

bors commented Mar 14, 2015

bors commented Mar 14, 2015

sfackler commented Mar 15, 2015

Manishearth commented Mar 15, 2015

alexcrichton commented Mar 18, 2015

Manishearth commented Mar 19, 2015

bors commented Mar 19, 2015

bors commented Mar 19, 2015

bors commented Mar 19, 2015

bors commented Mar 19, 2015

bors commented Mar 19, 2015

bors commented Mar 19, 2015

alexcrichton commented Mar 20, 2015

bors commented Mar 20, 2015

bors commented Mar 20, 2015

alexcrichton commented Mar 20, 2015