Skip to content

shift int/uint tests around to avoid code repetition #22582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

glacjay
Copy link
Contributor

@glacjay glacjay commented Feb 20, 2015

fix issue #22535

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Feb 21, 2015

Thanks for the PR! This looks basically good, but I wonder if the tests would be better placed in num itself? It's a bit arbitrary to plop them in usize.

@glacjay
Copy link
Contributor Author

glacjay commented Feb 21, 2015

@aturon Thanks for your review.

I just choose a most possible place in my opinion, because this tests are all for unsigned types. Should I move them to src/libstd/num/mod.rs or not?

@glacjay
Copy link
Contributor Author

glacjay commented Feb 21, 2015

@aturon I've just found that put mod tests in usize.rs will trigger "duplicate definition of type or module tests" error. I'll move tests to mod.rs, as you said, and submit a new PR.

@glacjay glacjay closed this Feb 21, 2015
@glacjay glacjay deleted the issue_22535 branch February 22, 2015 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants